[KAFKA-4480] kafka-configs will execute the removal of an invalid property and not report an error

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0.0
• Fix Version/s: 0.10.2.0
• Component/s: config
• Environment: CentOS Linux release 7.2.1511 (Core); java version "1.8.0_102"
• Assignee: Vahid Hashemian
• Reporter: Justin Manchester
• Created: 02/Dec/16 14:38
• Updated: 03/Jan/17 20:26
• Resolved: 31/Dec/16 18:49

Description

Problem:

kafka-configs will execute the removal of an invalid property and not report an error

Steps to Reproduce:

1. Add a config property to a topic:

kafka-configs --zookeeper localhost:2181 --entity-type topics --entity-name test1 --alter --add-config max.message.bytes=128000

2. Confirm config is present:

kafka-topics --zookeeper localhost:2181 --describe --topic test1
Topic:test1 PartitionCount:1 ReplicationFactor:1 Configs:max.message.bytes=128000
Topic: test1 Partition: 0 Leader: 0 Replicas: 0 Isr: 0

3. Remove config:

kafka-configs --zookeeper localhost:2181 --entity-type topics --entity-name test1 --alter --delete-config max.message.bytes=128000
Updated config for topic: "test1".

4. Config is still present and no error is thrown:

kafka-topics --zookeeper localhost:2181 --describe --topic test1
Topic:test1 PartitionCount:1 ReplicationFactor:1 Configs:max.message.bytes=128000
Topic: test1 Partition: 0 Leader: 0 Replicas: 0 Isr: 0

This is due to the "=128000" in the removal statement.

Impact:

1. We would expect there to be an error statement if an invalid property is specified for removal. This can lead to unforeseen consequences in heavily automated environments.

Issue Links

• relates to: KAFKA-4584 Fail the 'kafka-configs' command if the config to be removed does not exist
• links to: GitHub Pull Request #2218