[KAFKA-4459] rat license check not running in Jenkins

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11.0.0
• Assignee: Ewen Cheslack-Postava
• Reporter: Ismael Juma
• Created: 29/Nov/16 08:42
• Updated: 25/Jul/17 11:11
• Resolved: 01/Jun/17 16:33

Description

The following commit introduced files without a license, which causes rat to fail when run locally:

https://github.com/apache/kafka/commit/e035fc039598127e88f31739458f705290b1fdba

However, the build passed in Jenkins:

https://builds.apache.org/job/kafka-trunk-jdk7/1710/

Not sure why, but a potential culprit is the check for `.git` in the build:

if (new File('.git').exists()) {
  apply from: file('gradle/rat.gradle')
  rat {
    // Exclude everything under the directory that git should be ignoring via .gitignore or that isn't checked in. These
    // restrict us only to files that are checked in or are staged.
    def repo = Grgit.open(project.file('.'))
    excludes = new ArrayList<String>(repo.clean(ignore: false, directories: true, dryRun: true))
    // And some of the files that we have checked in should also be excluded from this check
    excludes.addAll([
        '**/.git/**',
        '**/build/**',
        'CONTRIBUTING.md',
        'gradlew',
        'gradlew.bat',
        '**/README.md'
    ])
  }
}

If the current directory in Jenkins is not the repo directory, it could fail.

Issue Links

• links to: GitHub Pull Request #3186