[KAFKA-4415] Reduce time to create and send MetadataUpdateRequest - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 0.10.1.0
Fix Version/s: 0.10.2.0
Component/s: None
Labels:
None

Description

As of current implementation, when controller receives ControlledShutdownRequest, it will 1) for every broker in the cluster, for every partition on the broker which wants to shutdown, create an instance of PartitionStateInfo and add it to ControllerBrokerRequestBatch.,updateMetadataRequestMap; and 2) for every broker, for every follower partitions on the broker which wants to shutdown, send one MetadataUpdateRequst to that broker.

In order to shutdown a broker, the controller will need to instantiate O(partitionNum * brokerNum) PartitionStateInfo. This is not efficient. The broker should only need to instantiate O(partitionNum) PartitionStateInfo.

Micro-benchmark results show that this optimization can reduce the time of processing ControlledShutdownRequest by 30%.