[KAFKA-4360] Controller may deadLock when autoLeaderRebalance encounter zk expired

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0.0, 0.9.0.1, 0.10.0.0, 0.10.0.1
• Fix Version/s: 0.10.2.0
• Component/s: controller
• Labels: bugfix reliability
• Flags: Important
• Assignee: Unassigned
• Reporter: tuyang
• Reviewer: Jiangjie Qin
• Created: 31/Oct/16 14:48
• Updated: 16/Mar/18 18:55
• Resolved: 09/Nov/16 18:38

Description

when controller has checkAndTriggerPartitionRebalance task in autoRebalanceScheduler，and then zk expired at that time. It will
run into deadlock.

we can restore the scene as below，when zk session expired，zk thread will call handleNewSession which defined in SessionExpirationListener, and it will get controllerContext.controllerLock，and then it will autoRebalanceScheduler.shutdown()，which need complete all the task in the autoRebalanceScheduler，but that threadPoll also need get controllerContext.controllerLock，but it has already owned by zk callback thread，which will then run into deadlock.

because of that，it will cause two problems at least, first is the broker’s id is cannot register to the zookeeper，and it will be considered as dead by new controller，second this procedure can not be stop by kafka-server-stop.sh, because shutdown function
can not get controllerContext.controllerLock also, we cannot shutdown kafka except using kill -9.

In my attachment, I upload a jstack file, which was created when my kafka procedure cannot shutdown by kafka-server-stop.sh.

I have met this scenes for several times，I think this may be a bug that not solved in kafka.

Issue Links

• duplicates: KAFKA-1429 Yet another deadlock in controller shutdown
• is duplicated by: KAFKA-6665 LeaderChangeListener.handleDataDeleted deadlock