Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4248

Consumer can return data from old regex subscription in poll()

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.10.1.0
    • consumer
    • None

    Description

      Because we only update the subscription from the metadata listener currently, it is possible when the user changes regex subscriptions to receive data from the old subscription. To fix this, we need to ensure that we rematch the new regex against the current metadata

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user hachikuji opened a pull request:

            https://github.com/apache/kafka/pull/1954

            KAFKA-4248: Consumer should rematch regex immediately in subscribe

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/hachikuji/kafka rematch-regex-on-subscribe

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/kafka/pull/1954.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #1954


            commit 335cc04efa6905ec812ef3ba14985b62c536933e
            Author: Jason Gustafson <jason@confluent.io>
            Date: 2016-10-03T20:03:25Z

            KAFKA-4248: Consumer should rematch regex immediately in subscribe


            githubbot ASF GitHub Bot added a comment - GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/1954 KAFKA-4248 : Consumer should rematch regex immediately in subscribe You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka rematch-regex-on-subscribe Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1954.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1954 commit 335cc04efa6905ec812ef3ba14985b62c536933e Author: Jason Gustafson <jason@confluent.io> Date: 2016-10-03T20:03:25Z KAFKA-4248 : Consumer should rematch regex immediately in subscribe

            Issue resolved by pull request 1954
            https://github.com/apache/kafka/pull/1954

            hachikuji Jason Gustafson added a comment - Issue resolved by pull request 1954 https://github.com/apache/kafka/pull/1954
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/kafka/pull/1954

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1954

            People

              hachikuji Jason Gustafson
              hachikuji Jason Gustafson
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: