Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4098

NetworkClient should not intercept all metadata requests on disconnect

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.1.0
    • Component/s: None
    • Labels:
      None

      Description

      It looks like we're missing a check in DefaultMetadataUpdater.maybeHandleDisconnecttion that the request was initiated by NetworkClient. We should do the same thing we do in maybeHandleCompletedReceive.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/kafka/pull/1798

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1798
          Hide
          ewencp Ewen Cheslack-Postava added a comment -

          Issue resolved by pull request 1798
          https://github.com/apache/kafka/pull/1798

          Show
          ewencp Ewen Cheslack-Postava added a comment - Issue resolved by pull request 1798 https://github.com/apache/kafka/pull/1798
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hachikuji opened a pull request:

          https://github.com/apache/kafka/pull/1798

          KAFKA-4098: NetworkClient should not intercept user metdata requests on disconnect

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hachikuji/kafka KAFKA-4098

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/kafka/pull/1798.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1798


          commit b94352753090617ff1992769328e484bfbf69407
          Author: Jason Gustafson <jason@confluent.io>
          Date: 2016-08-29T18:55:58Z

          KAFKA-4098: NetworkClient should not intercept user metdata requests on disconnect


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/1798 KAFKA-4098 : NetworkClient should not intercept user metdata requests on disconnect You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-4098 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1798.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1798 commit b94352753090617ff1992769328e484bfbf69407 Author: Jason Gustafson <jason@confluent.io> Date: 2016-08-29T18:55:58Z KAFKA-4098 : NetworkClient should not intercept user metdata requests on disconnect

            People

            • Assignee:
              hachikuji Jason Gustafson
              Reporter:
              hachikuji Jason Gustafson
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development