[KAFKA-4092] retention.bytes should not be allowed to be less than segment.bytes

• Type: Improvement
• Status: Reopened
• Priority: Minor
• Resolution: Unresolved
• Component/s: log
• Assignee: Dustin Cote
• Reporter: Dustin Cote
• Reviewer: Ewen Cheslack-Postava
• Created: 26/Aug/16 20:21
• Updated: 02/Mar/17 10:35

Description

Right now retention.bytes can be as small as the user wants but it doesn't really get acted on for the active segment if retention.bytes is smaller than segment.bytes. We shouldn't allow retention.bytes to be less than segment.bytes and validate that at startup.

Note that a PR for this was merged in 0.10.2.0, but reverted in the 0.10.2 branch (what will become 0.10.2.1) and trunk (see KAFKA-4788 for details). This is still worth doing, but the implementation needs to be a bit different: we should warn in TopicConfigHandler and we could potentially warn in KafkaConfig.

Issue Links

• links to: GitHub Pull Request #1796