[KAFKA-4087] DefaultParitioner Implementation Issue

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Bug
• Affects Version/s: 0.9.0.1, 0.10.0.1
• Component/s: producer
• Labels: partitioners producer
• Assignee: Bharat Viswanadham
• Reporter: Bharat Viswanadham
• Created: 25/Aug/16 19:13
• Updated: 23/Apr/17 01:12
• Resolved: 23/Apr/17 01:12

Description

In DefaultPartitioner implementation, when key is null
if (availablePartitions.size() > 0)

{ int part = Utils.toPositive(nextValue) % availablePartitions.size(); return availablePartitions.get(part).partition(); }

Where as when key is not null
return Utils.toPositive(Utils.murmur2(keyBytes)) % numPartitions;

We are returning partition by using total number of partitions.
Should n't we do the same as by considering only available partitions?

https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/internals/DefaultPartitioner.java#L67