[KAFKA-3934] Start scripts enable GC by default with no way to disable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.2.0
• Fix Version/s: 0.10.1.0
• Assignee: Grant Henke
• Reporter: Grant Henke
• Created: 07/Jul/16 15:00
• Updated: 09/Aug/16 16:15
• Resolved: 09/Aug/16 16:15

Description

In KAFKA-1127 the following line was added to kafka-server-start.sh:

EXTRA_ARGS="-name kafkaServer -loggc"

This prevents gc logging from being disabled without some unusual environment variable workarounds.

I suggest EXTRA_ARGS is made overridable like below:

if [ "x$EXTRA_ARGS" = "x" ]; then
    export EXTRA_ARGS="-name kafkaServer -loggc"
fi

Note: I am also not sure I understand why the existing code uses the "x" thing when checking the variable instead of the following:

export EXTRA_ARGS=${EXTRA_ARGS-'-name kafkaServer -loggc'}

This lets the variable be overridden to "" without taking the default.

Workaround: As a workaround the user should be able to set $KAFKA_GC_LOG_OPTS to fit their needs. Since kafka-run-class.sh will not ignore the -loggc parameter if that is set.

-loggc)
      if [ -z "$KAFKA_GC_LOG_OPTS" ]; then
        GC_LOG_ENABLED="true"
      fi
      shift

Issue Links

• links to: GitHub Pull Request #1631