[KAFKA-3761] Controller has RunningAsBroker instead of RunningAsController state

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.1.0
• Assignee: Roger Hoover
• Reporter: Ismael Juma
• Created: 26/May/16 23:51
• Updated: 31/May/17 00:00
• Resolved: 30/Jun/16 11:26

Description

In `KafkaServer.start`, we start `KafkaController`:

/* start kafka controller */
kafkaController = new KafkaController(config, zkUtils, brokerState, kafkaMetricsTime, metrics, threadNamePrefix)
kafkaController.startup()

Which sets the state to `RunningAsController` in `KafkaController.onControllerFailover`:

`brokerState.newState(RunningAsController)`

And this later gets set to `RunningAsBroker`.

This doesn't match the diagram in `BrokerStates`. junrao suggested that we should start the controller after we register the broker in ZK, but this seems tricky as we need to controller in `KafkaApis`.

Issue Links

• links to: GitHub Pull Request #1437
• links to: GitHub Pull Request #2935