[KAFKA-3747] Close `RecordBatch.records` when append to batch fails

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0.1
• Assignee: Ismael Juma
• Reporter: Ismael Juma
• Reviewer: Guozhang Wang
• Created: 23/May/16 16:34
• Updated: 24/May/16 08:15
• Resolved: 24/May/16 08:15

Description

We should close the existing `RecordBatch.records` when we create a new `RecordBatch` for the `TopicPartition`.

This would mean that we would only retain temporary resources like compression stream buffers for one `RecordBatch` per partition, which can have a significant impact when producers are dealing with slow brokers, see KAFKA-3704 for more details.

Issue Links

• links to: GitHub Pull Request #1418