Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-3747

Close `RecordBatch.records` when append to batch fails

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0.1
    • Component/s: None
    • Labels:
      None

      Description

      We should close the existing `RecordBatch.records` when we create a new `RecordBatch` for the `TopicPartition`.

      This would mean that we would only retain temporary resources like compression stream buffers for one `RecordBatch` per partition, which can have a significant impact when producers are dealing with slow brokers, see KAFKA-3704 for more details.

        Attachments

          Issue Links

          links to

          Web Link GitHub Pull Request #1418

            Activity

              People

              • Assignee:
                ijuma Ismael Juma
                Reporter:
                ijuma Ismael Juma
                Reviewer:
                Guozhang Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: