[KAFKA-3426] Improve protocol type errors when invalid sizes are received

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0.0
• Fix Version/s: 0.10.0.0
• Assignee: Ismael Juma
• Reporter: Ismael Juma
• Created: 19/Mar/16 00:18
• Updated: 17/May/16 14:32
• Resolved: 22/Mar/16 19:39

Description

We currently don't perform much validation on the size value read by the protocol types. This means that we end up throwing exceptions like `BufferUnderflowException`, `NegativeArraySizeException`, etc. `Schema.read` catches these exceptions and adds some useful information like:

throw new SchemaException("Error reading field '" + fields[i].name +
                                          "': " +
                                          (e.getMessage() == null ? e.getClass().getName() : e.getMessage()));

We could do even better by throwing a `SchemaException` with a more user friendly message.