Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:

      Description

      With the create topic ddl, some of the broker configs like topic.partition.count.map probably don't make sense anymore.

      1. kafka-300-v1.patch
        3 kB
        Swapnil Ghike
      2. kafka-325-v2.patch
        3 kB
        Swapnil Ghike
      3. kafka-325-v3.patch
        6 kB
        Swapnil Ghike

        Activity

        Jun Rao created issue -
        Neha Narkhede made changes -
        Field Original Value New Value
        Labels replication
        Jun Rao made changes -
        Labels replication optimization
        Jun Rao made changes -
        Original Estimate 24h [ 86400 ]
        Remaining Estimate 24h [ 86400 ]
        Joel Koshy made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        Swapnil Ghike made changes -
        Assignee Swapnil Ghike [ swapnilghike ]
        Swapnil Ghike made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Swapnil Ghike added a comment -

        This patch will conflict with the last patch in KAFKA-495.

        • Removed topic.partition.count.map from KafkaConfig.
        • Removed the check on partition id in LogManager.createLog.
        • Removed one unit test from LogManagerTest.
        Show
        Swapnil Ghike added a comment - This patch will conflict with the last patch in KAFKA-495 . Removed topic.partition.count.map from KafkaConfig. Removed the check on partition id in LogManager.createLog. Removed one unit test from LogManagerTest.
        Swapnil Ghike made changes -
        Attachment kafka-300-v1.patch [ 12544742 ]
        Hide
        Swapnil Ghike added a comment -

        Rebased.

        Show
        Swapnil Ghike added a comment - Rebased.
        Swapnil Ghike made changes -
        Attachment kafka-325-v2.patch [ 12544876 ]
        Hide
        Jun Rao added a comment -

        Thanks for the patch. Just one comment.

        KafkaConfig: Could you remove stateChangeQSize and monitoringPeriodSecs? Neither is actually used.

        Show
        Jun Rao added a comment - Thanks for the patch. Just one comment. KafkaConfig: Could you remove stateChangeQSize and monitoringPeriodSecs? Neither is actually used.
        Hide
        Swapnil Ghike added a comment -

        monitoringPeriodSecs seems to be used in SocketServer in starting a new processor and registerMBean.

        Show
        Swapnil Ghike added a comment - monitoringPeriodSecs seems to be used in SocketServer in starting a new processor and registerMBean.
        Hide
        Swapnil Ghike added a comment -

        Rebased and made the change.

        Show
        Swapnil Ghike added a comment - Rebased and made the change.
        Swapnil Ghike made changes -
        Attachment kafka-325-v3.patch [ 12545022 ]
        Hide
        Jun Rao added a comment -

        Thanks for patch v3. Committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for patch v3. Committed to 0.8.
        Jun Rao made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 0.8 [ 12317244 ]
        Resolution Fixed [ 1 ]
        Jun Rao made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        161d 3h 42m 1 Swapnil Ghike 11/Sep/12 23:10
        In Progress In Progress Resolved Resolved
        2d 3h 19m 1 Jun Rao 14/Sep/12 02:30
        Resolved Resolved Closed Closed
        4s 1 Jun Rao 14/Sep/12 02:30

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development