Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:

      Description

      With the create topic ddl, some of the broker configs like topic.partition.count.map probably don't make sense anymore.

      1. kafka-325-v3.patch
        6 kB
        Swapnil Ghike
      2. kafka-325-v2.patch
        3 kB
        Swapnil Ghike
      3. kafka-300-v1.patch
        3 kB
        Swapnil Ghike

        Activity

        Hide
        Jun Rao added a comment -

        Thanks for patch v3. Committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for patch v3. Committed to 0.8.
        Hide
        Swapnil Ghike added a comment -

        Rebased and made the change.

        Show
        Swapnil Ghike added a comment - Rebased and made the change.
        Hide
        Swapnil Ghike added a comment -

        monitoringPeriodSecs seems to be used in SocketServer in starting a new processor and registerMBean.

        Show
        Swapnil Ghike added a comment - monitoringPeriodSecs seems to be used in SocketServer in starting a new processor and registerMBean.
        Hide
        Jun Rao added a comment -

        Thanks for the patch. Just one comment.

        KafkaConfig: Could you remove stateChangeQSize and monitoringPeriodSecs? Neither is actually used.

        Show
        Jun Rao added a comment - Thanks for the patch. Just one comment. KafkaConfig: Could you remove stateChangeQSize and monitoringPeriodSecs? Neither is actually used.
        Hide
        Swapnil Ghike added a comment -

        Rebased.

        Show
        Swapnil Ghike added a comment - Rebased.
        Hide
        Swapnil Ghike added a comment -

        This patch will conflict with the last patch in KAFKA-495.

        • Removed topic.partition.count.map from KafkaConfig.
        • Removed the check on partition id in LogManager.createLog.
        • Removed one unit test from LogManagerTest.
        Show
        Swapnil Ghike added a comment - This patch will conflict with the last patch in KAFKA-495 . Removed topic.partition.count.map from KafkaConfig. Removed the check on partition id in LogManager.createLog. Removed one unit test from LogManagerTest.

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development