Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: clients
    • Labels:
      None

      Description

      Add support for Multi-Produce, and Multi-Fetch to the go client

        Activity

        AaronR created issue -
        Hide
        AaronR added a comment -

        For Review, an early version not finalized yet.

        Show
        AaronR added a comment - For Review, an early version not finalized yet.
        AaronR made changes -
        Field Original Value New Value
        Attachment kafka-314.patch [ 12519730 ]
        Hide
        Jeffrey Damick added a comment - - edited

        i'm the process of adding support for the new wire protocol, I don't know that we really want to add support for these as they are going away..

        Show
        Jeffrey Damick added a comment - - edited i'm the process of adding support for the new wire protocol, I don't know that we really want to add support for these as they are going away..
        Hide
        AaronR added a comment -

        True, the new wire protocol changes some of this. However, the bulk of the changes here are to update the GoClient to suport multi-topic, multi-partition in its internals. The change from the current [(topic,partition, messages),(topic,partition,messages)] over to the new [(topic,(partition,messages),(etc)] only changes a few lines of code. I considered this step 1 to get to step 2 being the new wire format. Not sure if you are interested in collaborating on this, sounds like it conflicts with work you are doing, so i should drop it?

        Show
        AaronR added a comment - True, the new wire protocol changes some of this. However, the bulk of the changes here are to update the GoClient to suport multi-topic, multi-partition in its internals. The change from the current [(topic,partition, messages),(topic,partition,messages)] over to the new [(topic,(partition,messages),(etc)] only changes a few lines of code. I considered this step 1 to get to step 2 being the new wire format. Not sure if you are interested in collaborating on this, sounds like it conflicts with work you are doing, so i should drop it?
        Hide
        Jeffrey Damick added a comment -

        I agree, I was thinking about taking this and reworking it for the new protocol. I need to look at the patch a bit more but maybe we should just fold this patch into that one, then we just drop the old format. What do u think?

        Show
        Jeffrey Damick added a comment - I agree, I was thinking about taking this and reworking it for the new protocol. I need to look at the patch a bit more but maybe we should just fold this patch into that one, then we just drop the old format. What do u think?
        Hide
        AaronR added a comment -

        That sounds good. But, I also have the 297, 298 issues out there (298 is a pretty big issue for me although you only see it under certain uses cases, mine being one). What if we drop all of them together, get it working on github https://github.com/araddon/kafka and then submit all at once? I don't think 296 has been included yet either. That way we can see each others changes more easily?

        Show
        AaronR added a comment - That sounds good. But, I also have the 297, 298 issues out there (298 is a pretty big issue for me although you only see it under certain uses cases, mine being one). What if we drop all of them together, get it working on github https://github.com/araddon/kafka and then submit all at once? I don't think 296 has been included yet either. That way we can see each others changes more easily?
        Hide
        Colin B. added a comment -

        Old bug. Client libraries, such as this Go library, are no longer being maintained in the main project.

        Please close. Won't Fix.

        Show
        Colin B. added a comment - Old bug. Client libraries, such as this Go library, are no longer being maintained in the main project. Please close. Won't Fix.
        Jun Rao made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Jun Rao made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            AaronR
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development