Kafka
  1. Kafka
  2. KAFKA-313

Add JSON output and looping options to ConsumerOffsetChecker

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 0.8.2
    • Component/s: None
    • Labels:

      Description

      Adds:

      • '--loop N' - causes the program to loop forever, sleeping for up to N seconds between loops (loop time minus collection time, unless that's less than 0, at which point it will just run again immediately)
      • '--asjson' - display as a JSON string instead of the more human readable output format.

      Neither of the above depend on each other (you can loop in the human readable output, or do a single shot execution with JSON output). Existing behavior/output maintained if neither of the above are used. Diff Attached.

      Impacted files:

      core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala

        Activity

        Hide
        Joel Koshy added a comment -

        This tool also needs to be updated for 0.8 for the broker failure and other system tests.

        Show
        Joel Koshy added a comment - This tool also needs to be updated for 0.8 for the broker failure and other system tests.
        Hide
        Jay Kreps added a comment -

        Is JSON better than CSV for this kind of thing? CSV is sometimes more shell friendly and that is what we are using for the perf tests...

        If we like JSON then I am +1

        Show
        Jay Kreps added a comment - Is JSON better than CSV for this kind of thing? CSV is sometimes more shell friendly and that is what we are using for the perf tests... If we like JSON then I am +1
        Hide
        Joel Koshy added a comment -

        I worked with Dave on another version of this patch but will need to revisit. We can add CSV as well.

        Show
        Joel Koshy added a comment - I worked with Dave on another version of this patch but will need to revisit. We can add CSV as well.

          People

          • Assignee:
            Unassigned
            Reporter:
            Dave DeMaagd
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development