[KAFKA-2461] request logger no longer logs extra information in debug mode

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.9.0.0
• Assignee: Ashish Singh
• Reporter: Gwen Shapira
• Created: 24/Aug/15 18:50
• Updated: 03/Sep/15 20:22
• Resolved: 03/Sep/15 05:07

Description

Currently request logging calls are identical for trace and debug:

if(requestLogger.isTraceEnabled)
        requestLogger.trace("Completed request:%s from connection %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d"
                .format(requestDesc, connectionId, totalTime, requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime))
      else if(requestLogger.isDebugEnabled)
        requestLogger.debug("Completed request:%s from connection %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d"
          .format(requestDesc, connectionId, totalTime, requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime))

I think in the past (3 refactoring steps ago), we used to print more information about specific topics and partitions in debug mode.