[KAFKA-2407] Only create a log directory when it will be used

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.2.1
• Fix Version/s: 0.9.0.0
• Assignee: Grant Henke
• Reporter: Grant Henke
• Reviewer: Gwen Shapira
• Created: 05/Aug/15 17:29
• Updated: 05/Aug/15 18:47
• Resolved: 05/Aug/15 18:47

Description

Currently kafka-run-class.sh will default the $LOG_DIR and create the directory regardless of it's use. This can cause permissions issues depending on what users are utilizing tools such as kafka-topics.sh.

Further down in the script there is logic to detect whether $KAFKA_LOG4J_OPTS is set. If it is not set this is assumed to be a tool call and the script sets tools-log4j.properties which only uses the console appender. In this scenario a logging directory is not needed. In all other cases $KAFKA_LOG4J_OPTS will be set and we can move the $LOG_DIR defaulting & creation logic there. For example kafka-server-start.sh sets $KAFKA_LOG4J_OPTS to use its own log4j.properties file which respects the $LOG_DIR/kafka.log4j.dir setting.