[KAFKA-2388] subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.0.0
• Assignee: Jason Gustafson
• Reporter: Jiangjie Qin
• Created: 31/Jul/15 03:54
• Updated: 27/Aug/15 00:19
• Resolved: 27/Aug/15 00:19

Description

According to the mailing list discussion on the consumer interface, we'll replace:

public void subscribe(String... topics);
public void subscribe(TopicPartition... partitions);
public Set<TopicPartition> subscriptions();

with:

void subscribe(List<String> topics, RebalanceCallback callback);
void assign(List<TopicPartition> partitions);
List<String> subscriptions();
List<TopicPartition> assignments();

We don't need the unsubscribe APIs anymore.

The RebalanceCallback would look like:

interface RebalanceCallback {
  void onAssignment(List<TopicPartition> partitions);
  void onRevocation(List<TopicPartition> partitions);

  // handle non-existing topics, etc.
  void onError(Exception e);
}