[KAFKA-2150] FetcherThread backoff need to grab lock before wait on condition.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: newbie++
• Assignee: Harsha
• Reporter: Jiangjie Qin
• Reviewer: Guozhang Wang
• Created: 25/Apr/15 07:48
• Updated: 13/Nov/15 15:33
• Resolved: 12/May/15 00:43

Description

Saw the following error:
kafka.api.ProducerBounceTest > testBrokerFailure STANDARD_OUT
[2015-04-25 00:40:43,997] ERROR [ReplicaFetcherThread-0-0], Error due to (kafka.server.ReplicaFetcherThread:103)
java.lang.IllegalMonitorStateException
at java.util.concurrent.locks.ReentrantLock$Sync.tryRelease(ReentrantLock.java:127)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1239)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.fullyRelease(AbstractQueuedSynchronizer.java:1668)
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2107)
at kafka.server.AbstractFetcherThread.doWork(AbstractFetcherThread.scala:95)
at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:60)
[2015-04-25 00:40:47,064] ERROR [ReplicaFetcherThread-0-1], Error due to (kafka.server.ReplicaFetcherThread:103)
java.lang.IllegalMonitorStateException
at java.util.concurrent.locks.ReentrantLock$Sync.tryRelease(ReentrantLock.java:127)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1239)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.fullyRelease(AbstractQueuedSynchronizer.java:1668)
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2107)
at kafka.server.AbstractFetcherThread.doWork(AbstractFetcherThread.scala:95)
at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:60)
We should grab the lock before waiting on the condition.

Issue Links

• is related to: KAFKA-1461 Replica fetcher thread does not implement any back-off behavior