[KAFKA-2090] Remove duplicate check to metadataFetchInProgress

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.0.0
• Assignee: Tim Brooks
• Reporter: Tim Brooks
• Created: 03/Apr/15 17:36
• Updated: 09/Apr/15 02:07
• Resolved: 09/Apr/15 02:07

Description

In the NetworkClient class on a call to poll() there are three checks (timeToNextMetadataUpdate, timeToNextReconnectAttempt, waitForMetadataFetch) made to see if a metadata update should be made. If all of these == 0 then an update is performed.

However, in the if block a second check is made to metadataFetchInProgress. This only make sense in a multithreaded environment. However, as the variable is not volatile I suspect this is not the case.