[KAFKA-2050] Avoid calling .size() on java.util.ConcurrentLinkedQueue

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: network
• Assignee: Tim Brooks
• Reporter: Tim Brooks
• Reviewer: Jay Kreps
• Created: 25/Mar/15 21:11
• Updated: 05/Apr/15 15:52
• Resolved: 04/Apr/15 22:24

Description

Generally, it seems to be preferred to avoid calling .size() on a Java ConcurrentLinkedQueue. This is an O(N) operation as it must iterate through all the nodes.

Calling this every time through the loop makes this issue worse under high load. It seems like the same functionality can be attained by just polling and checking for null.

This is more imperative and less functional, but it seems alright since this is in lower-level networking code.