Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1992

Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.9.0.0
    • None
    • None

    Description

      Follow up from Jun's review:

      "Should we just remove requiredAcks completely since checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?"

      Answer is: Yes, we should

      Attachments

        1. KAFKA-1992_2015-03-03_14:16:34.patch
          9 kB
          Gwen Shapira
        2. KAFKA-1992_2015-03-03_17:17:43.patch
          10 kB
          Gwen Shapira
        3. KAFKA-1992_2015-03-06_13:34:20.patch
          12 kB
          Gwen Shapira
        4. KAFKA-1992_2015-03-06_13:36:32.patch
          13 kB
          Gwen Shapira
        5. KAFKA-1992_2015-03-06_13:37:39.patch
          14 kB
          Gwen Shapira
        6. KAFKA-1992.patch
          4 kB
          Gwen Shapira

        Activity

          People

            gwenshap Gwen Shapira
            gwenshap Gwen Shapira
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: