[KAFKA-18016] Fix bugs in handling piggyback acknowledgements in ShareFetch

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Assignee: Shivsundar R
• Reporter: Shivsundar R
• Created: 14/Nov/24 14:01
• Updated: 16/Dec/24 22:21
• Resolved: 18/Nov/24 16:48

Description

Currently, when a ShareFetch is processed and response is received, we use the fetchAcknowledgements map to determine the acknowledgements sent per partition and call the callback accordingly. But there is a chance this map was updated by the ShareFetchEvent before the response was processed.
This means we could potentially lose out on sending acknowledgements. This bug was found while testing using the ShareRoundTripWorker with 100k records and a target production rate of 1000 messages per second.

Issue Links

• links to: GitHub Pull Request #17824