[KAFKA-1782] Junit3 Misusage

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.0.0
• Labels: newbie
• Assignee: Alexander Pakulov
• Reporter: Guozhang Wang
• Reviewer: Guozhang Wang
• Created: 18/Nov/14 20:35
• Updated: 15/Aug/15 04:54
• Resolved: 15/Aug/15 04:54

Description

This is found while I was working on KAFKA-1580: in many of our cases where we explicitly extend from junit3suite (e.g. ProducerFailureHandlingTest), we are actually misusing a bunch of features that only exist in Junit4, such as (expected=classOf). For example, the following code

import org.scalatest.junit.JUnit3Suite
import org.junit.Test

import java.io.IOException

class MiscTest extends JUnit3Suite {
  @Test (expected = classOf[IOException])
  def testSendOffset() {
  }
}

will actually pass even though IOException was not thrown since this annotation is not supported in Junit3. Whereas

import org.junit._

import java.io.IOException

class MiscTest extends JUnit3Suite {
  @Test (expected = classOf[IOException])
  def testSendOffset() {
  }
}

or

import org.scalatest.junit.JUnitSuite
import org.junit._

import java.io.IOException

class MiscTest extends JUnit3Suite {
  @Test (expected = classOf[IOException])
  def testSendOffset() {
  }
}

or

import org.junit._

import java.io.IOException

class MiscTest {
  @Test (expected = classOf[IOException])
  def testSendOffset() {
  }
}

will fail.

I would propose to not rely on Junit annotations other than @Test itself but use scala unit test annotations instead, for example:

import org.junit._

import java.io.IOException

class MiscTest {
  @Test
  def testSendOffset() {
    intercept[IOException] {
      //nothing
    }
  }
}

will fail with a clearer stacktrace.

Issue Links

• is duplicated by: KAFKA-2398 Transient test failure for SocketServerTest - Socket closed.