Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-16092 Queues for Kafka
  3. KAFKA-17742

Move DelayedShareFetchPurgatory declaration to ReplicaManager

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0
    • None
    • None

    Description

      Hi, as per comments https://github.com/apache/kafka/pull/17380#issuecomment-2399040546 and https://github.com/apache/kafka/pull/17380#issuecomment-2400431605 , we need to do the following - 

      1. Declare the delayed share fetch purgatory inside ReplicaManager along with the existing purgatories. We don't need a reference to this purgatory outside of ReplicaManager, we can just add accessor methods.
      2. Currently, we check the produce/fetch purgatory when a replica becomes the follower or a replica is deleted from a broker through ReplicaManager. applyLocalFollowersDelta and ReplicaManager.applyDelta. We should do the same for share purgatory.
      3. Perform a checkAndComplete when HWM is updated
      4. Perform a shutdown of the delayed share fetch purgatory like the others in ReplicaManager

      Attachments

        Issue Links

          Activity

            People

              adixitconfluent Abhinav Dixit
              adixitconfluent Abhinav Dixit
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: