[KAFKA-17159] Make sure kafka-cluster-test-kit-executor get down when closing KafkaClusterTestKit - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.9.0
Component/s: None
Labels:
None

Description

When trying to remove `TestUtils.waitForCondition` in https://github.com/apache/kafka/pull/16499, kraft may have thread leak.

We can use ThreadUtils#shutdownExecutorServiceQuietly [0] to replace the block in KafkaClusterTestKie#close [1].

[0] https://github.com/apache/kafka/blob/f595802cc752ed01dc74e9ab932209fe25a9d10b/clients/src/main/java/org/apache/kafka/common/utils/ThreadUtils.java#L71-L92

[1] https://github.com/apache/kafka/blob/f595802cc752ed01dc74e9ab932209fe25a9d10b/core/src/test/java/kafka/testkit/KafkaClusterTestKit.java#L640-L643

Attachments

Issue Links

links to

GitHub Pull Request #16633

Activity

People

Assignee:: PoAn Yang

Reporter:: PoAn Yang

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 18/Jul/24 14:05

Updated:: 22/Jul/24 17:48

Resolved:: 22/Jul/24 17:48