[KAFKA-17113] Flaky Test in GlobalStreamThreadTest#shouldThrowStreamsExceptionOnStartupIfExceptionOccurred

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.9.0
• Component/s: streams, unit tests
• Assignee: Unassigned
• Reporter: Ao Li
• Created: 10/Jul/24 17:51
• Updated: 27/Nov/24 23:33
• Resolved: 27/Nov/24 23:33

Description

The `shouldThrowStreamsExceptionOnStartupIfExceptionOccurred` test expects `
globalStreamThread.start` throws `startupException` when startup fails. This may not be true in some slow machines. 

 

class GlobalStreamThread {
  Exception startupException;
  void initialize() {
    try {
      ...
    } catch (Exception e) {
      startupException = e;
    }
    ...
    setState(State.DEAD);
  }
  void start() {
    super.start();
    while (stillInitializing()) {
      Utils.sleep(1);
      if (startupException != null) {
        throw startupexception;
      }
    }
    if (inErrorState()) {
      throw new IllegalStateException("Initialization for the global stream thread failed");
    }
  }
}

Consider the following schedule:

main:start:`startupException != null`
GlobalStreamThread:initialize:`startupException = e;`
GlobalStreamThread:initialize:`setState(State.DEAD);`
main:start:`inErrorState()`
main:start:`throw new IllegalStateException`

 
The function throws `IllegalStateException("Initialization for the global stream thread failed")` instead of `startupexception`

Issue Links

• is fixed by: KAFKA-17100 GlobalStreamThread#start should not busy-wait