[KAFKA-16942] Use ConcurrentHashMap in RecordAccumulator#nodeStats

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Do
• Component/s: clients, producer
• Assignee: Kuan Po Tseng
• Reporter: Kuan Po Tseng
• Created: 12/Jun/24 15:58
• Updated: 17/Jun/24 21:29
• Resolved: 14/Jun/24 08:37

Description

per discussed in https://github.com/apache/kafka/pull/16231#discussion_r1635345881

Through the ConcurrentMapBenchmark, we observed that in scenarios where write operations (i.e., computeIfAbsent) constitute 10%, the get performance of CopyOnWriteMap is lower compared to ConcurrentHashMap. However, when iterating over entrySet and values, CopyOnWriteMap performs better than ConcurrentHashMap.

In RecordAccumulator#nodeStats, the computeIfAbsent method is rarely triggered, and we only use the get method to read data. Therefore, switching to ConcurrentHashMap would gain better performance.

Issue Links

• links to: GitHub Pull Request #16305