Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-16935

Automatically wait for cluster startup in embedded Connect integration tests

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Done
    • 3.8.0
    • 3.8.0
    • None
    • None

    Description

      It's a common idiom in our integration tests to start an embedded Kafka and Connect cluster and then immediately afterwards wait for each worker in the Connect cluster to complete startup. Separating these two actions into separate steps makes our tests lengthier and can even lead to bugs and flakiness if the second step is accidentally omitted (see https://github.com/apache/kafka/pull/16286 for one example).

      Instead, we should default to automatically awaiting the complete startup of every worker in an embedded Connect cluster when EmbeddedConnect::start is invoked, and require callers to opt out if they do not want to automatically wait for startup to complete when invoking that method.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ChrisEgerton Chris Egerton
            ChrisEgerton Chris Egerton
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment