[KAFKA-16920] Flaky test testControlledShutdown() - kafka.server.BrokerLifecycleManagerTest

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.9.0
• Assignee: Gaurav Narula
• Reporter: Igor Soarez
• Created: 08/Jun/24 12:48
• Updated: 09/Jun/24 11:18
• Resolved: 09/Jun/24 11:18

Description

Several tests failed in this pipeline because testControlledShutdown did not clean up properly:

https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16232/3/tests

Stack trace

org.opentest4j.AssertionFailedError: Found 1 unexpected threads during @BeforeAll: `controlled-shutdown-lifecycle-manager-event-handler` ==> expected: <true> but was: <false>
    at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
    at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
    at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
    at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
    at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
    at kafka.utils.TestUtils$.verifyNoUnexpectedThreads(TestUtils.scala:1917)
    at kafka.server.QuorumTestHarness$.setUpClass(QuorumTestHarness.scala:489)
    at kafka.server.QuorumTestHarness.setUpClass(QuorumTestHarness.scala)

Note that the thread name controlled-shutdown-lifecycle-manager-event-handler originates from the BrokerLifecycleManager instance created in kafka.server.BrokerLifecycleManagerTest#testControlledShutdown.

 

The test itself failed with the following stack trace:

org.opentest4j.AssertionFailedError: expected: <RUNNING> but was: <RECOVERY>
    at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
    at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
    at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
    at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
    at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
    at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
    at kafka.server.BrokerLifecycleManagerTest.$anonfun$testControlledShutdown$3(BrokerLifecycleManagerTest.scala:160)
    at kafka.server.BrokerLifecycleManagerTest.testControlledShutdown(BrokerLifecycleManagerTest.scala:157) 

Regardless of the test failure, the BrokerLifecycleManger thread should have been shutdown.

Issue Links

• links to: GitHub Pull Request #16252