[KAFKA-16895] RemoteCopyLagSegments metric taking active segment into account

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.7.0, 3.7.1
• Fix Version/s: 3.9.0
• Component/s: Tiered-Storage
• Assignee: Francois Visconte
• Reporter: Francois Visconte
• Created: 05/Jun/24 11:19
• Updated: 15/Jun/24 01:11
• Resolved: 15/Jun/24 01:11

Description

The RemoteCopyLagSegment is off by 1 because it also includes the active segment into account while the RemoteCopyLagBytes does substract the size of active segment:

 long bytesLag = log.onlyLocalLogSegmentsSize() - log.activeSegment().size();
String topic = topicIdPartition.topic();
int partition = topicIdPartition.partition();
long segmentsLag = log.onlyLocalLogSegmentsCount();
brokerTopicStats.recordRemoteCopyLagBytes(topic, partition, bytesLag);
brokerTopicStats.recordRemoteCopyLagSegments(topic, partition, segmentsLag);

Issue Links

• is a child of: KAFKA-16947 Kafka Tiered Storage V2
• links to: GitHub Pull Request #16210