[KAFKA-16823] Extract LegacyConsumer-specific unit tests from generic KafkaConsumerTest

• Type: Task
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Component/s: clients, consumer
• Labels: kip-848-client-support
• Assignee: PoAn Yang
• Reporter: Lianet Magrans
• Created: 22/May/24 20:41
• Updated: 21/Jun/24 02:27

Description

Currently the KafkaConsumerTest file contains unit tests that apply to both consumer implementations, but also tests that apply to the legacy consumer only. We should consider splitting the tests that apply to the legacy only into their own LegacyConsumerTest file (aligning with the existing AsyncKafkaConsumerTest). End result would be: 

KafkaConsumerTest -> unit tests that apply to both consumers. 

LegacyKafkaConsumerTest -> unit tests that apply only to the LegacyKafkaConsumer, either because of the logic they test, or the way they are written (file to be created with this task)

AsyncKafkaConsumerTest -> unit tests that apply only to the AsyncKafkaConsumer (this file already exist)

 

Issue Links

• links to: GitHub Pull Request #16228

Sub-Tasks

• Enable KafkaConsumerTest#configurableObjectsShouldSeeGeneratedClientId to work with CLASSIC and CONSUMER: Resolved
• Enable testMeasureCommitSyncDuration, testMeasureCommittedDurationOnFailure, testInvalidGroupMetadata, testMeasureCommittedDuration, testOffsetsForTimesTimeout, testBeginningOffsetsTimeout and testEndOffsetsTimeout for AsyncConsumer: Resolved
• Revisit `KafkaConsumerTest#testBeginningOffsetsTimeout` for AsyncConsumer: Resolved
• Enable KafkaConsumerTest#testFetchProgressWithMissingPartitionPosition for AsyncConsumer: Resolved
• Enable valid test case in KafkaConsumerTest for AsyncKafkaConsumer: Resolved
• Revisit FindCoordinatorResponse in KafkaConsumerTest: Resolved
• Revisit testMissingOffsetNoResetPolicy for AsyncConsumer: Resolved
• Revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure for AsyncKafkaConsumer: Resolved
• testClientInstanceId, testClientInstanceIdInvalidTimeout, and testClientInstanceIdNoTelemetryReporterRegistered should include CONSUMER protocol: Resolved
• Flaky test testMissingOffsetNoResetPolicy for new consumer: Resolved
• Make sure FindCoordinatorResponse get created before consumer: Patch Available