Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-16610

Replace "Map#entrySet#forEach" by "Map#forEach"

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.8.0
    • None
    • None

    Description

      Targets
          Occurrences of 'entrySet().forEach' in Project
      Found occurrences in Project  (16 usages found)
          Unclassified  (16 usages found)
              kafka.core.main  (9 usages found)
                  kafka.server  (4 usages found)
                      ControllerApis.scala  (2 usages found)
                          ControllerApis  (2 usages found)
                              handleIncrementalAlterConfigs  (1 usage found)
                                  774 controllerResults.entrySet().forEach(entry => response.responses().add(
                              handleLegacyAlterConfigs  (1 usage found)
                                  533 controllerResults.entrySet().forEach(entry => response.responses().add(
                      ControllerConfigurationValidator.scala  (2 usages found)
                          ControllerConfigurationValidator  (2 usages found)
                              validate  (2 usages found)
                                  99 config.entrySet().forEach(e => {
                                  114 config.entrySet().forEach(e => properties.setProperty(e.getKey, e.getValue))
                  kafka.server.metadata  (5 usages found)
                      AclPublisher.scala  (1 usage found)
                          AclPublisher  (1 usage found)
                              onMetadataUpdate  (1 usage found)
                                  73 aclsDelta.changes().entrySet().forEach(e =>
                      ClientQuotaMetadataManager.scala  (3 usages found)
                          ClientQuotaMetadataManager  (3 usages found)
                              handleIpQuota  (1 usage found)
                                  119 quotaDelta.changes().entrySet().forEach { e =>
                              update  (2 usages found)
                                  54 quotasDelta.changes().entrySet().forEach { e =>
                                  99 quotaDelta.changes().entrySet().forEach { e =>
                      KRaftMetadataCache.scala  (1 usage found)
                          KRaftMetadataCache  (1 usage found)
                              getClusterMetadata  (1 usage found)
                                  491 topic.partitions().entrySet().forEach { entry =>
              kafka.core.test  (1 usage found)
                  unit.kafka.integration  (1 usage found)
                      KafkaServerTestHarness.scala  (1 usage found)
                          KafkaServerTestHarness  (1 usage found)
                              getTopicNames  (1 usage found)
                                  349 controllerServer.controller.findAllTopicIds(ANONYMOUS_CONTEXT).get().entrySet().forEach {
              kafka.metadata.main  (3 usages found)
                  org.apache.kafka.controller  (2 usages found)
                      QuorumFeatures.java  (1 usage found)
                          toString()  (1 usage found)
                              144 localSupportedFeatures.entrySet().forEach(f -> features.add(f.getKey() + ": " + f.getValue()));
                      ReplicationControlManager.java  (1 usage found)
                          createTopic(ControllerRequestContext, CreatableTopic, List<ApiMessageAndVersion>, Map<String, CreatableTopicResult>, List<ApiMessageAndVersion>, boolean)  (1 usage found)
                              732 newParts.entrySet().forEach(e -> assignments.put(e.getKey(),
                  org.apache.kafka.metadata.properties  (1 usage found)
                      MetaPropertiesEnsemble.java  (1 usage found)
                          toString()  (1 usage found)
                              610 logDirProps.entrySet().forEach(
              kafka.metadata.test  (1 usage found)
                  org.apache.kafka.controller  (1 usage found)
                      ReplicationControlManagerTest.java  (1 usage found)
                          createTestTopic(String, int[][], Map<String, String>, short)  (1 usage found)
                              307 configs.entrySet().forEach(e -> topic.configs().add(
              kafka.streams.main  (1 usage found)
                  org.apache.kafka.streams.processor.internals  (1 usage found)
                      StreamsMetadataState.java  (1 usage found)
                          onChange(Map<HostInfo, Set<TopicPartition>>, Map<HostInfo, Set<TopicPartition>>, Map<TopicPartition, PartitionInfo>)  (1 usage found)
                              317 topicPartitionInfo.entrySet().forEach(entry -> this.partitionsByTopic
              kafka.tools.main  (1 usage found)
                  org.apache.kafka.tools  (1 usage found)
                      LeaderElectionCommand.java  (1 usage found)
                          electLeaders(Admin, ElectionType, Optional<Set<TopicPartition>>)  (1 usage found)
                              178 failed.entrySet().forEach(entry -> {

      origin discussion: https://github.com/apache/kafka/pull/15786#discussion_r1577656938

       

       

      Attachments

        Issue Links

          Activity

            People

              frankvicky TengYao Chi
              chia7712 Chia-Ping Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: