[KAFKA-16588] broker shutdown hangs when `log.segment.delete.delay.ms` is zero

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.8.0
• Assignee: PoAn Yang
• Reporter: Chia-Ping Tsai
• Created: 19/Apr/24 16:32
• Updated: 01/May/24 09:11
• Resolved: 01/May/24 09:11

Description

see https://github.com/apache/kafka/blob/f22ad6645bfec0b38e820e0090261c9f6b421a74/core/src/main/scala/kafka/log/LogManager.scala#L1154

If `log.segment.delete.delay.ms` is zero, We call `take` even though the `logsToBeDeleted` is empty, and `KafkaScheduler#shutdown` call `shutdown` rather than `shudownNow` (https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/util/KafkaScheduler.java#L134)

Hence, the thread won't be completed forever, and it blocks the shutdown of broker.

We should replace the `take` by `poll` since we have checked the element before.

BTW, the zero is allowed (https://github.com/apache/kafka/blob/f22ad6645bfec0b38e820e0090261c9f6b421a74/storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java#L258)

Issue Links

• links to: GitHub Pull Request #15773