[KAFKA-16074] Fix thread leaks in ReplicaManagerTest

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Assignee: Luke Chen
• Reporter: Luke Chen
• Created: 02/Jan/24 11:19
• Updated: 10/Jan/24 11:56
• Resolved: 10/Jan/24 11:56

Description

Following @dajac 's finding in #15063, I found we also create new RemoteLogManager in ReplicaManagerTest, but didn't close them.

While investigating ReplicaManagerTest, I also found there are other threads leaking:

1. remote fetch reaper thread. It's because we create a reaper thread in test, which is not expected. We should create a mocked one like other purgatory instance.
2. Throttle threads. We created a quotaManager to feed into the replicaManager, but didn't close it. Actually, we have created a global quotaManager instance and will close it on AfterEach. We should re-use it.
3. replicaManager and logManager didn't invoke close after test.

Issue Links

• blocks: KAFKA-16072 Create Junit 5 extension to detect thread leak
• links to: GitHub Pull Request #15077