[KAFKA-16032] Review client errors thrown on OffsetFetch and OffsetCommit failures

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.8.0
• Component/s: clients, consumer
• Labels: kip-848-client-support offset
• Assignee: Lianet Magrans
• Reporter: Lianet Magrans
• Created: 19/Dec/23 16:45
• Updated: 02/Feb/24 22:20
• Resolved: 26/Jan/24 13:43

Description

OffsetFetch and OffsetCommit handle errors separately. There are some issues to review around this, to ensure that we keep propagating the same exceptions as the legacy consumer:

1. Ensure same behaviour of legacy coordinator for expected commit errors: propagating the error.exception(), or CommitFailedException, depending on the error (Ex. commit requests that fail with FENCED_INSTANCE_ID or UNKNOWN_MEMBER_ID should throw a CommitFailedException instead of the error specific ones)
2. Ensure same behaviour of legacy coordinator for unexpected errors: all unexpected should fail with KafkaException, even if retriable.
3. Consider if we could unify the error handling for both, commit and fetch? (Downside, even though there are common errors, there are some that are not handled similarly in both requests (ex. UNKNOWN_TOPIC_OR_PARTITION throwing a non-retriable KafkaException for fetch requests, but throwing a retriable UnknownTopicOrPartitionException for commit requests).

Issue Links

• links to: GitHub Pull Request #15202