[KAFKA-15913] Migrate AsyncKafkaConsumerTest away from ConsumerTestBuilder

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Component/s: clients, consumer
• Labels: consumer-threading-refactor
• Assignee: Lucas Brutschy
• Reporter: Philip Nee
• Created: 28/Nov/23 19:36
• Updated: 26/Feb/24 21:32
• Resolved: 18/Dec/23 21:42

Description

ConsumerTestBuilder is meant to be an unit testing utility; however, we seem to use Mockito#spy quite liberally.  This is not the right testing strategy because we basically turn unit testing into integration testing.

 

While the current unit tests run fine, we should probably make the mocking using Mockito#mock by default and test each dependency independently.

 

The ask here is

1. Make mock(class) by default
2. Provide more flexible interface for the testBuilder to allow user to configure spy or mock.  Or, let user pass in their own mock.

Issue Links

• links to: GitHub Pull Request #14930