[KAFKA-1581] Log cleaner should have an option to ignore messages without keys

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 0.9.0.0
• Assignee: Manikumar
• Reporter: Joel Jacob Koshy
• Created: 08/Aug/14 19:34
• Updated: 24/May/15 09:18
• Resolved: 24/May/15 09:17

Description

Right now, there is a strict requirement that compacted topics contain only messages with keys. This makes sense, but the issue with a hard requirement is that if it fails the cleaner quits. We should probably allow ignoring these messages (with a warning). Alternatively, we can catch this scenario (instead of the hard requirement) and just skip compaction for that partition.

This came up because I saw an invalid message (compressed and without a key) in the offsets topic which broke both log compaction and the offset load process. I filed KAFKA-1580 to prevent that from happening in the first place but KAFKA-1580 is only for internal topics. In the general case (compacted non-internal topics) we would not want the cleaners to exit permanently due to an invalid (key-less) message in one of the partitions since that would prevent compaction for other partitions as well.

Issue Links

• is related to: KAFKA-1580 Reject producer requests to internal topics
• is related to: KAFKA-1374 LogCleaner (compaction) does not support compressed topics
• is related to: KAFKA-1755 Improve error handling in log cleaner