[KAFKA-15508] Method always return the same value ApplicationEventProcessor.java

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.5.1
• Fix Version/s: 3.7.0
• Component/s: clients, consumer
• Labels: consumer-threading-refactor kip-848-e2e kip-848-preview
• Assignee: Kirk True
• Reporter: Svyatoslav
• Reviewer: Jun Rao
• Created: 26/Sep/23 11:28
• Updated: 24/Oct/23 21:21
• Resolved: 24/Oct/23 21:21

Description

I'm not sure but i think that this is a bug, because method 'process' in ApplicationEventProcessor.java always return true:

    private boolean process(final PollApplicationEvent event) {
        Optional<RequestManager> commitRequestManger = registry.get(RequestManager.Type.COMMIT);
        if (!commitRequestManger.isPresent()) {
            return true;
        }

        CommitRequestManager manager = (CommitRequestManager) commitRequestManger.get();
        manager.updateAutoCommitTimer(event.pollTimeMs);
        return true;
    }

Issue Links

• is related to: KAFKA-14274 Introduce FetchRequestManager to integrate fetch into new consumer threading refactor