[KAFKA-15380] Try complete actions after callback

• Type: Sub-task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Assignee: Justine Olshan
• Reporter: Justine Olshan
• Created: 18/Aug/23 22:58
• Updated: 20/Sep/23 04:18
• Resolved: 11/Sep/23 16:51

Description

KIP-890 part 1 introduced the callback request type. It is used to execute a callback after KafkaApis.handle has returned. We did not account for tryCompleteActions at the end of handle when making this change.

In tests, we saw produce p99 increase dramatically (likely because we have to wait for another request before we can complete DelayedProduce). As a result, we should add the tryCompleteActions after the callback as well. In testing, this improved the produce performance.

Issue Links

• links to: GitHub Pull Request #14197