[KAFKA-15085] Make Timer.java implement AutoCloseable

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Component/s: core
• Labels: Newbie newbie
• Assignee: Joobi S B
• Reporter: Divij Vaidya
• Reviewer: Divij Vaidya
• Created: 14/Jun/23 09:30
• Updated: 19/Jun/23 13:53
• Resolved: 19/Jun/23 13:53

Description

Many automatic bug finders will flag a warning if an object of class which is marked as AutoCloseable but is not closed properly in the code. Hence, as a best practice we should implement AutoCloseable for classes which require resources to be released after shutdown.

Timer.java should implement AutoCloseable and ShutDown should be replaced with close() method.

Note that this interface change does not require a KIP since Timer.java is not a user facing public class.

This was discussed here: https://github.com/apache/kafka/pull/13820#discussion_r1222654614 

Issue Links

• links to: GitHub Pull Request #13872