[KAFKA-14919] MM2 ForwardingAdmin tests should not conflate admin operations

• Type: Test
• Status: In Progress
• Priority: Minor
• Resolution: Unresolved
• Component/s: mirrormaker
• Labels: newbie
• Assignee: Anton Liauchuk
• Reporter: Greg Harris
• Created: 18/Apr/23 22:09
• Updated: 05/Aug/24 20:04

Description

The MirrorConnectorsWithCustomForwardingAdminIntegrationTest uses a special implementation of ForwardingAdmin which records admin operations in a static ConcurrentMap, which is then used to perform assertions.

This has the problem that one variable (allTopics) is used to perform assertions for multiple different methods (adding topics, adding partitions, and syncing configs), despite these operations each being tested separately. This leads to the confusing behavior where each test appears to assert that a particular operation has taken place, and instead asserts that at least one of the operations has taken place. This allows a regression or timeout in one operation to be hidden by the others, making the behavior of the tests much less predictable.

These tests and/or the metadata store should be changed so that the tests are isolated from one another, and actually perform the assertions that correspond to their titles.

Issue Links

• Discovered while testing: KAFKA-14905 Failing tests in MM2 ForwardingAdmin test since KIP-894
• links to: GitHub Pull Request #16143