[KAFKA-14868] Remove some forgotten metrics when the replicaManager is closed

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Assignee: hudeqi
• Reporter: hudeqi
• Created: 29/Mar/23 14:38
• Updated: 19/Apr/23 16:49
• Resolved: 19/Apr/23 16:49

Description

In some current classes, some metrics are always registered when loading, but it often occurs that some or all metrics are forgotten to be removed when closing. For example, in the ReplicaManager class, IsrExpandsPerSec, IsrShrinksPerSec, and FailedIsrUpdatesPerSec are all removed by omission.

The problem of not closing the metric in the replicaManager has been solved in the patch. As for how to improve the KafkaMetricsGroup to make the inspection of such issues more general, there is no conclusive solution.

Issue Links

• links to: GitHub Pull Request #13471