[KAFKA-14794] Unable to deserialize base64 JSON strings

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5.0
• Assignee: José Armando García Sancio
• Reporter: José Armando García Sancio
• Created: 08/Mar/23 17:14
• Updated: 14/Mar/23 19:22
• Resolved: 14/Mar/23 19:22

Description

Problem

The following test fails:

@Test
public void testBinaryNode() throws IOException {
    byte[] expected = new byte[] {5, 2, 9, 4, 1, 8, 7, 0, 3, 6};
    StringWriter writer = new StringWriter();
    ObjectMapper mapper = new ObjectMapper();

    mapper.writeTree(mapper.createGenerator(writer), new BinaryNode(expected));

    JsonNode binaryNode = mapper.readTree(writer.toString());

    assertTrue(binaryNode.isTextual(), binaryNode.toString());
    byte[] actual = MessageUtil.jsonNodeToBinary(binaryNode, "Test base64 JSON string");
    assertEquals(expected, actual);
}

with the following error:

 Gradle Test Run :clients:test > Gradle Test Executor 20 > MessageUtilTest > testBinaryNode() FAILED
    java.lang.RuntimeException: Test base64 JSON string: expected Base64-encoded binary data.
        at org.apache.kafka.common.protocol.MessageUtil.jsonNodeToBinary(MessageUtil.java:165)
        at org.apache.kafka.common.protocol.MessageUtilTest.testBinaryNode(MessageUtilTest.java:102)

The reason for the failure is because FasterXML Jackson deserializes base64 JSON strings to a TextNode not to a BinaryNode.

Solution

The method MessageUtil::jsonNodeToBinary should not assume that the input JsonNode is always a BinaryNode. It should also support decoding TextNode.

JsonNode::binaryValue is supported by both BinaryNode and TextNode.

Issue Links

• links to: GitHub Pull Request #13363