Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-14760

Move ThroughputThrottler, break connect-runtime dependency on tools

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.6.0
    • connect, tools
    • None

    Description

      Currently there is only one dependency on the `tools` module, `connect-runtime`.
      This dependency is only for one class, the ThroughputThrottler. This class is used by:

      1. tools main ProducerPerformance
      2. tools main VerifiableProducer
      3. runtime main SchemaSourceConnector
      4. runtime main VerifiableSourceConnector
      5. runtime test MonitorableSourceConnector

      For KAFKA-14627, I want to be able to have `tools` (test) depend on `connect-runtime` (test). This is because we are adding a connect-specific command-line utility, and wish to re-use some of the existing connect test infrastructure to unit test the new command-line utility. Unfortunately naively adding this new dependency to tools causes a circular dependency that prevents the project from building.

      Instead of refactoring the connect-specific test utilities out to a new package that both runtime and tools can depend on, it appears to make more sense to move the more generic `ThroughputThrottler` class into some common package.

      This common package could be:
      1. clients
      2. server common
      3. some other existing package which would be a new dependency for tools
      4. a new package consisting of just the `ThroughputThrottler` class

      I'm not sure which one of these makes the most sense, and would appreciate guidance on what would make the most sense for ownership and maintenance.

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. KAFKA-15030 Add connect-plugin-path command line tool

          • Major - Major loss of function.
          • Resolved
          is required by

          New Feature - A new feature of the product, which has yet to be developed. KAFKA-14627 Modernize Connect plugin discovery

          • Major - Major loss of function.
          • Resolved
          relates to

          Sub-task - The sub-task of the issue KAFKA-17857 Move AbstractResetIntegrationTest and subclasses to tools

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. KAFKA-2807 Movement of throughput throttler to common broke upgrade tests

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. KAFKA-2752 Add clean bounce system test for distributed Copycat

          • Major - Major loss of function.
          • Resolved

          Test - A new unit, integration or system test. KAFKA-15239 producerPerformance system test for old client failed after v3.5.0

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. KAFKA-14762 Remove 0_8_2_LATEST from rolling upgrade system test

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Task - A task that needs to be done. KAFKA-14759 Move test-only connectors from connect-runtime to test-specific module

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #13313

          Activity

            People

              gharris1727 Greg Harris
              gharris1727 Greg Harris
              Ismael Juma Ismael Juma
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: