[KAFKA-14406] Double iteration of records in batches to be restored

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Component/s: streams
• Assignee: Nicholas Telford
• Reporter: A. Sophie Blee-Goldman
• Created: 19/Nov/22 01:30
• Updated: 21/Nov/22 09:54
• Resolved: 19/Nov/22 01:31

Description

While restoring a batch of records, RocksDBStore was iterating the ConsumerRecords, building a list of KeyValues, and then iterating that list of KeyValues to add them to the RocksDB batch.

Simply adding the key and value directly to the RocksDB batch prevents this unnecessary second iteration, and the creation of itermediate KeyValue objects, improving the performance of state restoration, and reducing unnecessary object allocation.

(thanks to Nick Telford for finding this)

Issue Links

• links to: GitHub Pull Request #12842