Kafka
  1. Kafka
  2. KAFKA-1420

Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests

    Details

    • Type: Bug Bug
    • Status: In Progress
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 0.8.3
    • Component/s: None
    • Labels:

      Description

      This is a follow-up JIRA from KAFKA-1389.

      There are a bunch of places in the unit tests where we misuse AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK to create topics, where TestUtils.createTopic needs to be used instead.

      1. KAFKA-1420.patch
        13 kB
        Jonathan Natkins
      2. KAFKA-1420_2014-08-10_23:03:46.patch
        31 kB
        Jonathan Natkins
      3. KAFKA-1420_2014-08-10_14:12:05.patch
        32 kB
        Jonathan Natkins
      4. KAFKA-1420_2014-08-02_11:04:15.patch
        31 kB
        Jonathan Natkins
      5. KAFKA-1420_2014-07-30_11:24:55.patch
        16 kB
        Jonathan Natkins
      6. KAFKA-1420_2014-07-30_11:18:26.patch
        16 kB
        Jonathan Natkins

        Issue Links

          Activity

          Jun Rao made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          Joe Stein made changes -
          Fix Version/s 0.8.3 [ 12328745 ]
          Fix Version/s 0.8.2 [ 12326167 ]
          Neha Narkhede made changes -
          Assignee Jun Rao [ junrao ] Jonathan Natkins [ natty ]
          Reviewer Jun Rao [ junrao ]
          Neha Narkhede made changes -
          Assignee Neha Narkhede [ nehanarkhede ] Jun Rao [ junrao ]
          Neha Narkhede made changes -
          Assignee Jonathan Natkins [ natty ] Neha Narkhede [ nehanarkhede ]
          Jonathan Natkins made changes -
          Assignee Jonathan Natkins [ natty ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420_2014-08-10_23:03:46.patch [ 12660930 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420_2014-08-10_14:12:05.patch [ 12660874 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420_2014-08-02_11:04:15.patch [ 12659489 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420_2014-07-30_11:24:55.patch [ 12658698 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420_2014-07-30_11:18:26.patch [ 12658694 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420.patch [ 12658262 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420.patch [ 12658262 ]
          Jonathan Natkins made changes -
          Attachment KAFKA-1420.patch [ 12658242 ]
          Jonathan Natkins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Guozhang Wang made changes -
          Description This is a follow-up JIRA from KAFKA-1389.

          There are a bunch of places in the unit tests where we mis-use AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK
          This is a follow-up JIRA from KAFKA-1389.

          There are a bunch of places in the unit tests where we misuse AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK to create topics, where TestUtils.createTopic needs to be used instead.
          Guozhang Wang made changes -
          Summary Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests
          Guozhang Wang made changes -
          Description This is a follow-up JIRA from KAFKA-1389.

          There are a bunch of places in the unit tests where we mis-use
          This is a follow-up JIRA from KAFKA-1389.

          There are a bunch of places in the unit tests where we mis-use AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK
          Guozhang Wang made changes -
          Description This is a follow-up JIRA from KAFKA-1389 This is a follow-up JIRA from KAFKA-1389.

          There are a bunch of places in the unit tests where we mis-use
          Guozhang Wang made changes -
          Labels newbie
          Neha Narkhede made changes -
          Fix Version/s 0.8.2 [ 12326167 ]
          Guozhang Wang made changes -
          Field Original Value New Value
          Link This issue is related to KAFKA-1389 [ KAFKA-1389 ]
          Guozhang Wang created issue -

            People

            • Assignee:
              Jonathan Natkins
              Reporter:
              Guozhang Wang
              Reviewer:
              Jun Rao
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development