Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.2.0
    • Fix Version/s: 0.8.2.0
    • Component/s: None
    • Labels:
      None

      Description

      All unit tests are disabled since they hang transiently (see details in KAFKA-1391).

      1. KAFKA-1397_2014-04-28_14:48:32.patch
        57 kB
        Timothy Chen
      2. KAFKA-1397_2014-04-28_17:08:49.patch
        64 kB
        Timothy Chen
      3. KAFKA-1397_2014-04-30_14:55:28.patch
        58 kB
        Timothy Chen
      4. KAFKA-1397_2014-05-01_15:53:57.patch
        55 kB
        Timothy Chen
      5. KAFKA-1397_2014-05-01_18:12:24.patch
        64 kB
        Timothy Chen
      6. KAFKA-1397_2014-05-02_13:38:02.patch
        58 kB
        Timothy Chen
      7. KAFKA-1397_2014-05-05_11:17:59.patch
        58 kB
        Timothy Chen
      8. KAFKA-1397_2014-05-05_14:00:29.patch
        59 kB
        Timothy Chen
      9. KAFKA-1397.patch
        57 kB
        Timothy Chen

        Issue Links

          Activity

          Jun Rao created issue -
          Hide
          Jim Plush added a comment -

          what was the regression that caused topic deletion to stop working?

          Show
          Jim Plush added a comment - what was the regression that caused topic deletion to stop working?
          Hide
          Jun Rao added a comment -

          The original implementation never fully worked.

          Show
          Jun Rao added a comment - The original implementation never fully worked.
          Timothy Chen made changes -
          Field Original Value New Value
          Attachment KAFKA-1397.patch [ 12642115 ]
          Hide
          Timothy Chen added a comment -

          Created reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Created reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Hide
          Neha Narkhede added a comment -

          Timothy Chen Can you please explain the issue that your patch attempts to fix? I couldn't find anything on the JIRA or reviewboard.

          Show
          Neha Narkhede added a comment - Timothy Chen Can you please explain the issue that your patch attempts to fix? I couldn't find anything on the JIRA or reviewboard.
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-04-28_14:48:32.patch [ 12642340 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-04-28_17:08:49.patch [ 12642365 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-04-30_14:55:28.patch [ 12642734 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-05-01_15:53:57.patch [ 12642945 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-05-01_18:12:24.patch [ 12642979 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-05-02_13:38:02.patch [ 12643112 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-05-05_11:17:59.patch [ 12643398 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Timothy Chen made changes -
          Attachment KAFKA-1397_2014-05-05_14:00:29.patch [ 12643426 ]
          Hide
          Timothy Chen added a comment -

          Updated reviewboard https://reviews.apache.org/r/20745/
          against branch origin/trunk

          Show
          Timothy Chen added a comment - Updated reviewboard https://reviews.apache.org/r/20745/ against branch origin/trunk
          Hide
          Jun Rao added a comment -

          Thanks for the patch. +1 and committed to trunk.

          Show
          Jun Rao added a comment - Thanks for the patch. +1 and committed to trunk.
          Jun Rao made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Timothy Chen [ tnachen ]
          Fix Version/s 0.8.2 [ 12326167 ]
          Resolution Fixed [ 1 ]
          Chris Riccomini made changes -
          Link This issue is related to SAMZA-374 [ SAMZA-374 ]
          Hide
          Stefan Miklosovic added a comment -

          I am not sure what I am doing wrong but it seems to me this does not work in 0.8.2.1

          I am doing this

          $ bin/zookeeper-server-start.sh config/zookeeper.properties
          $ bin/kafka-server-start.sh config/server.properties
          $ bin/kafka-topics.sh --zookeeper 127.0.0.1:2181 --create --topic someTopic --partitions 10 --replication-factor 1
          $ bin/kafka-topics.sh --list // gives me "someTopic"
          $ bin/kafka-topics.sh --zookeeper 127.0.0.1:2181 --delete --topic someTopic
          $ bin/kafka-topics.sh --list // gives me "someTopic - marked for deletion"

          and this is there forever, even when I stop broker and zookeeper and start it once again, nothing changes, it is there forever.

          I set delete.topics.enable=true in server.properties for broker

          Show
          Stefan Miklosovic added a comment - I am not sure what I am doing wrong but it seems to me this does not work in 0.8.2.1 I am doing this $ bin/zookeeper-server-start.sh config/zookeeper.properties $ bin/kafka-server-start.sh config/server.properties $ bin/kafka-topics.sh --zookeeper 127.0.0.1:2181 --create --topic someTopic --partitions 10 --replication-factor 1 $ bin/kafka-topics.sh --list // gives me "someTopic" $ bin/kafka-topics.sh --zookeeper 127.0.0.1:2181 --delete --topic someTopic $ bin/kafka-topics.sh --list // gives me "someTopic - marked for deletion" and this is there forever, even when I stop broker and zookeeper and start it once again, nothing changes, it is there forever. I set delete.topics.enable=true in server.properties for broker
          Hide
          Sriharsha Chintalapani added a comment -

          Stefan Miklosovic
          It looks like you are setting the wrong property , its not "delete.topics.enable" . Can you try setting "delete.topic.enable" (topic is not plural) to true

          Show
          Sriharsha Chintalapani added a comment - Stefan Miklosovic It looks like you are setting the wrong property , its not "delete.topics.enable" . Can you try setting "delete.topic.enable" (topic is not plural) to true
          Hide
          Stefan Miklosovic added a comment -

          Yes it is "delete.topic.enable", that was my typo in the original post, the behaviour is the same. Could you confirm this?

          Show
          Stefan Miklosovic added a comment - Yes it is "delete.topic.enable", that was my typo in the original post, the behaviour is the same. Could you confirm this?
          Hide
          Sriharsha Chintalapani added a comment -

          Stefan Miklosovic I did a quick test on a single kafka 0.8.2.1 . I am not able to reproduce this it takes a bit of time but the topic gets deleted.
          Just to check make sure you don't have any producer or consumer sending any requests while the delete topic is going on or just set auto.creation.topic.enable to false in server.properties

          ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic
          Topic:test-topic PartitionCount:10 ReplicationFactor:1 Configs:
          Topic: test-topic Partition: 0 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 1 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 2 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 3 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 4 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 5 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 6 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 7 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 8 Leader: 0 Replicas: 0 Isr: 0
          Topic: test-topic Partition: 9 Leader: 0 Replicas: 0 Isr: 0
          ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀
          » ./bin/kafka-topics.sh --zookeeper localhost:2181 --delete --topic test-topic
          Topic test-topic is marked for deletion.
          Note: This will have no impact if delete.topic.enable is not set to true.
          ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀
          » ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic
          Topic:test-topic PartitionCount:10 ReplicationFactor:1 Configs:
          Topic: test-topic Partition: 0 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 1 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 2 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 3 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 4 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 5 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 6 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 7 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 8 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 9 Leader: -1 Replicas: 0 Isr:

          ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀
          » ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic
          Topic:test-topic PartitionCount:10 ReplicationFactor:1 Configs:
          Topic: test-topic Partition: 0 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 1 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 2 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 3 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 4 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 5 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 6 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 7 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 8 Leader: -1 Replicas: 0 Isr:
          Topic: test-topic Partition: 9 Leader: -1 Replicas: 0 Isr:
          ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀
          » ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic

          Last command doesn't show the topic .

          Show
          Sriharsha Chintalapani added a comment - Stefan Miklosovic I did a quick test on a single kafka 0.8.2.1 . I am not able to reproduce this it takes a bit of time but the topic gets deleted. Just to check make sure you don't have any producer or consumer sending any requests while the delete topic is going on or just set auto.creation.topic.enable to false in server.properties ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic Topic:test-topic PartitionCount:10 ReplicationFactor:1 Configs: Topic: test-topic Partition: 0 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 1 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 2 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 3 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 4 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 5 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 6 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 7 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 8 Leader: 0 Replicas: 0 Isr: 0 Topic: test-topic Partition: 9 Leader: 0 Replicas: 0 Isr: 0 ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀ » ./bin/kafka-topics.sh --zookeeper localhost:2181 --delete --topic test-topic Topic test-topic is marked for deletion. Note: This will have no impact if delete.topic.enable is not set to true. ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀ » ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic Topic:test-topic PartitionCount:10 ReplicationFactor:1 Configs: Topic: test-topic Partition: 0 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 1 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 2 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 3 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 4 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 5 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 6 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 7 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 8 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 9 Leader: -1 Replicas: 0 Isr: ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀ » ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic Topic:test-topic PartitionCount:10 ReplicationFactor:1 Configs: Topic: test-topic Partition: 0 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 1 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 2 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 3 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 4 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 5 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 6 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 7 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 8 Leader: -1 Replicas: 0 Isr: Topic: test-topic Partition: 9 Leader: -1 Replicas: 0 Isr: ⚙ ⮀ ~/build/kafka_2.10-0.8.2.1 ⮀ » ./bin/kafka-topics.sh --zookeeper localhost:2181 --describe --topic test-topic Last command doesn't show the topic .
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          20d 20h 41m 1 Jun Rao 06/May/14 18:39

            People

            • Assignee:
              Timothy Chen
              Reporter:
              Jun Rao
            • Votes:
              2 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development