[KAFKA-13752] Using `equals` instead of `==` when Uuid compare in Java

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1, 3.3.0
• Component/s: clients

Language

Java

• Assignee: Unassigned
• Reporter: Xiaobing Fang
• Created: 17/Mar/22 11:55
• Updated: 22/Mar/22 08:42
• Resolved: 22/Mar/22 08:42

Description

Uuid.ZERO_UUID == new Uuid(0L, 0L)

is true in scala, but in java is false.

 

So this test run sccessfully. Is this the expected situation??

@Test
public void testTopicIdAndNullTopicNameRequests() {
    // Construct invalid MetadataRequestTopics. We will build each one separately and ensure the error is thrown.
    List<MetadataRequestData.MetadataRequestTopic> topics = Arrays.asList(
            new MetadataRequestData.MetadataRequestTopic().setName("topic").setTopicId(new Uuid(0L, 0L)));

    // if version is 10 or 11, the invalid topic metadata should return an error
    List<Short> invalidVersions = Arrays.asList((short) 10, (short) 11);
    invalidVersions.forEach(version ->
        topics.forEach(topic -> {
            MetadataRequestData metadataRequestData = new MetadataRequestData().setTopics(Collections.singletonList(topic));
            MetadataRequest.Builder builder = new MetadataRequest.Builder(metadataRequestData);
            assertThrows(UnsupportedVersionException.class, () -> builder.build(version));
        })
    );
}

Issue Links

• links to: GitHub Pull Request #11912