[KAFKA-1365] Second Manual preferred replica leader election command always fails

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.8.1
• Fix Version/s: 0.8.1.1
• Component/s: controller, tools
• Assignee: Neha Narkhede
• Reporter: Ryan Berdeen
• Created: 07/Apr/14 20:42
• Updated: 27/May/14 18:42
• Resolved: 18/Apr/14 01:32

Description

After running kafka-preferred-replica-election.sh once, a second run will fail with "Preferred replica leader election currently in progress for ...".

The /admin/preferred_replica_election key is never deleted from ZooKeeper, because the "isTriggeredByAutoRebalance" parameter to onPreferredReplicaElection (https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L614) is used incorrectly. In the automatic case (https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1119), it is set to false. In the manual case (https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1266) the parameter is not passed, so it defaults to true.

Issue Links

• is depended upon by: KAFKA-1380 0.8.1.1 release candidate